CUMULUS-350 Update queue-granules to use cumulus-message-adapter #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 1, 2018 15:16
Removes a lot of extra logic from the granule queueing function.
marchuffnagle
changed the title
marchuffnagle
changed the title
|
In addition to updating the queue-granules task to use the message adapter, this PR also greatly simplifies the granule queuing code. |
marchuffnagle
requested review from
sethvincent,
indiejames,
matthewhanson,
scisco,
kkelly51,
abarciauskas-bgse,
laurenfrederick and
jennyhliu
laurenfrederick
approved these changes
Mar 2, 2018
| * See schemas/input.json and schemas/config.json for detailed event description | ||
| * | ||
| * @param {Object} event - Lambda event object | ||
| * @returns {Promise} - see schemas/output.json for detailed output schema |
There was a problem hiding this comment.
This is returning an Object, not a Promise, right?
There was a problem hiding this comment.
It's an async function, so it's returning a Promise.
| @@ -39,6 +39,7 @@ | |||
| "license": "Apache-2.0", | |||
| "dependencies": { | |||
| "@cumulus/common": "^1.0.1", | |||
| "@cumulus/cumulus-message-adapter-js": "0.0.1-beta.3", | |||
There was a problem hiding this comment.
We should make this 1.0.0
There was a problem hiding this comment.
I created CUMULUS-367 to deal with this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.